New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Switch to new Slicer logo in module panel #5877
Conversation
Switch to the new Slicer logo: it is more compact than the old one and works with both dark and bright background (see Slicer#5367). For crisp rendering of the new icon, Qt::AA_UseHighDpiPixmaps application option is now enabled. If higher-resolution variants of icons are provided by ...@2x.png, ...@3x.png, ... names then they are now used on high-DPI displays. Move the logo to the module panel dockable widget's header to save space. See discussion at Slicer#5820 for more details. Co-authored-by: James Butler <jbutler@sonovol.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into the higher quality pixmaps for icons! I was still using the same resolution when replacing images for the new slicer logo as part of #5366. Do you think it will be ok to include the new logo here in the module panel title, but still have the old logo for the app icon? I know it would be great to include the saved space sooner but maybe it should be tied to the transition of the other logo updates?
Thank you @lassoan for implementing this! It looks perfect to me, and a good compromise between branding and space. |
Makes sense. I'll add your other logo replacement commit to this pull request. |
This is a change to a flat style logo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
This is a follow-up to #5820 (did not force-push to the same pull request to preserve the content of that branch).
If this pull request is merged then these pull requests can be closed:
Switch to the new Slicer logo: it is more compact than the old one and works with both dark and bright background (see #5367).
The logo was moved to the module panel dockable widget's header to save space. See discussion at #5820 for more details.
Welcome module before:
Welcome module after:
Available height for module GUI increased by 18%:
Module panel can be still drag-and-dropped:
2021-09-19_17-10-50.mp4
For crisp rendering of the new icon, Qt::AA_UseHighDpiPixmaps application option is now enabled.
If higher-resolution variants of icons are provided by ...@2x.png, ...@3x.png, ... names then they are now used on high-DPI displays.
Before:
After:
Setting up high-resolution icons on high-DPI screens will come in a follow-up commit (basically we just need to rename our high-resolution icon versions to follow the basename@2x.png, basename@3x.png, ... naming convention).