Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Switch to new Slicer logo in module panel #5877

Merged
merged 2 commits into from Sep 20, 2021

Conversation

lassoan
Copy link
Contributor

@lassoan lassoan commented Sep 19, 2021

This is a follow-up to #5820 (did not force-push to the same pull request to preserve the content of that branch).

If this pull request is merged then these pull requests can be closed:


Switch to the new Slicer logo: it is more compact than the old one and works with both dark and bright background (see #5367).

The logo was moved to the module panel dockable widget's header to save space. See discussion at #5820 for more details.

Welcome module before:

image

Welcome module after:

image

Available height for module GUI increased by 18%:

image

Module panel can be still drag-and-dropped:

2021-09-19_17-10-50.mp4

For crisp rendering of the new icon, Qt::AA_UseHighDpiPixmaps application option is now enabled.
If higher-resolution variants of icons are provided by ...@2x.png, ...@3x.png, ... names then they are now used on high-DPI displays.

Before:

image

After:

image

Setting up high-resolution icons on high-DPI screens will come in a follow-up commit (basically we just need to rename our high-resolution icon versions to follow the basename@2x.png, basename@3x.png, ... naming convention).

Switch to the new Slicer logo: it is more compact than the old one and works with both dark and bright background (see Slicer#5367).

For crisp rendering of the new icon, Qt::AA_UseHighDpiPixmaps application option is now enabled.
If higher-resolution variants of icons are provided by ...@2x.png, ...@3x.png, ... names then they are now used on high-DPI displays.

Move the logo to the module panel dockable widget's header to save space. See discussion at Slicer#5820 for more details.

Co-authored-by: James Butler <jbutler@sonovol.com>
@lassoan lassoan self-assigned this Sep 19, 2021
Copy link
Contributor

@jamesobutler jamesobutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into the higher quality pixmaps for icons! I was still using the same resolution when replacing images for the new slicer logo as part of #5366. Do you think it will be ok to include the new logo here in the module panel title, but still have the old logo for the app icon? I know it would be great to include the saved space sooner but maybe it should be tied to the transition of the other logo updates?

@cpinter
Copy link
Member

cpinter commented Sep 20, 2021

Thank you @lassoan for implementing this! It looks perfect to me, and a good compromise between branding and space.

@lassoan
Copy link
Contributor Author

lassoan commented Sep 20, 2021

Do you think it will be ok to include the new logo here in the module panel title, but still have the old logo for the app icon? I know it would be great to include the saved space sooner but maybe it should be tied to the transition of the other logo updates?

Makes sense. I'll add your other logo replacement commit to this pull request.

This is a change to a flat style logo.
@lassoan
Copy link
Contributor Author

lassoan commented Sep 20, 2021

Now all the Slicer logos are updated to the new one:

image

Copy link
Member

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@lassoan lassoan merged commit c0a9033 into Slicer:master Sep 20, 2021
@lassoan lassoan deleted the module-panel-new-slicer-logo branch September 20, 2021 14:53
@jamesobutler jamesobutler mentioned this pull request Sep 21, 2021
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants