ENH: Create markups node put into menu for toolbar #5901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
The design is still discussed here: #5889 (comment) |
jamesobutler
force-pushed
the
markups-node-creation
branch
from
c9ab329
to
8729156
Compare
jamesobutler
force-pushed
the
markups-node-creation
branch
from
8729156
to
02c96bb
Compare
|
Updated image |
jamesobutler
force-pushed
the
markups-node-creation
branch
3 times, most recently
from
ec52194
to
77eea85
Compare
jamesobutler
force-pushed
the
markups-node-creation
branch
from
77eea85
to
5fc5bec
Compare
|
Closing PR as proposed changes do not appear that they will be accepted and I'm not proceeding to resolve merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #5889 (comment) to put the create markup node actions in the Markups Toolbar within a menu of a QToolButton. Markups is a pluggable framework where more markups can be registered and added into Slicer and creating a new button in the toolbar for each registered markup is not sustainable as it will only make the Markups toolbar larger.