BUG: Fix incorrect error message in vtkMRMLColorTableNode

[pieper]

Typo in error message makes debugging more difficult

[pieper]

I make this one character fix using the github web editor and it seems that the commit message shows up in a way that fails the check. I think it's actually fine to ignore unless someone knows how to fix it.

[jamesobutler]

@pieper re https://slicer.readthedocs.io/en/latest/developer_guide/style_guide.html#commits, the subject line is not capitalized because after the commit prefix it is fix and not Fix.

Here it describes the commit prefix, followed by a colon, followed by a space, followed by a capitalized A-Z character.

Slicer/.github/workflows/commit-message.yml

Line 21 in a943aa8

pattern: '^(ENH|PERF|BUG|STYLE|DOC|COMP): ([A-Z])+'

BUG: fix incorrect error message fails the regex at
BUG: f

[jamesobutler]

This confusion was previously reported in #6692, so we could try and improve the example message to better indicate what the regex means. If enforcing the capitalization is not desired, then updating the Slicer docs about contributing to remove the note that the subject line should be capitalized.

[pieper]

Wow, thanks for pointing that out @jamesobutler. I did not look at the regexp carefully. I read the error message and also the link to the Slicer documentation and never thought capitalization would be the issue. The current message is misleading IMO, since it explicitly complains about the "type" being wrong. I'll make a PR to change the message (and hope I get the commit message formatted correctly!).

I'm not sure starting with a capital letter should be a hard requirement but I'll ignore that for now. If someone will provide the review approval the commit message can be fixed during the squash and merge I believe.