BUG: Fix sample data set labels not appearing on large desktop monitors #6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
reviewed
Dec 12, 2022
| # two columns of buttons fit into the size of the Welcome module's minimum width | ||
| # on screens with a various resolution and scaling (see qt.QDesktopWidget().size, | ||
| # desktop.devicePixelRatioF(), qt.QDesktopWidget().physicalDpiX()) | ||
| iconSize = qt.QSize(int(mainWindow.iconSize.width() * 6), int(mainWindow.iconSize.height() * 4)) |
There was a problem hiding this comment.
Thanks for fixing this 👌🙏
Are the multipliers 6 and 4 required?
There was a problem hiding this comment.
Without the multipliers the thumbnails would be as small as the toolbar icons - too small to be useful:
There was a problem hiding this comment.
I understand now. Thanks for clarifying.
jcfr
approved these changes
Dec 12, 2022
| # two columns of buttons fit into the size of the Welcome module's minimum width | ||
| # on screens with a various resolution and scaling (see qt.QDesktopWidget().size, | ||
| # desktop.devicePixelRatioF(), qt.QDesktopWidget().physicalDpiX()) | ||
| iconSize = qt.QSize(int(mainWindow.iconSize.width() * 6), int(mainWindow.iconSize.height() * 4)) |
There was a problem hiding this comment.
I understand now. Thanks for clarifying.
|
With this change, the rendering is definitely improved on my workstation:
|
|
Increasing the width of the module panel allow to nicely makes use of the available space:
|
|
Thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue of clipped labels in Sample Data module by using the default icon size as a basis, which is more robust than computing it relative to window size.
Before the fix:
After the fix:
Tested on both large desktop and small laptop screens.