Expose markups JSON reader/writer #6756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
changed the title
lassoan
force-pushed
the
markups-json
branch
3 times, most recently
from
a4c15dd
to
4ed048c
Compare
When markup files were saved using the "Export to file..." feature then display properties were not included in the file.
Some curve features were only available for the curve in world coordinate system. This is generally good, because developers should be encouraged to perform computations in the world coordinate system (take into account parent transforms). However, in some cases it can be useful to perform computations in the curve's local coordinate system. To allow performing computations on curve points in the local coordinate system if needed (but not making it as convenient as computations in the world coordinate system), static methods are added, which can be used with points in any coordinate system.
THe method returns the ROI bounds in the Object coordinate system.
lassoan
force-pushed
the
markups-json
branch
from
4ed048c
to
07f3f0d
Compare
Allows custom markup classes (implemented outside Slicer core) to store additional properties in the markups file in JSON. vtkMRMLMarkupsJsonElement, vtkMRMLMarkupsJsonReader, and vtkMRMLMarkupsJsonWriter provide a simple JSON reading/writing interface without exposing the internal RapidJSON implementation. Fixed saving of coded entries (such as units, quantityCode, derivationCode) in markup json files.
lassoan
force-pushed
the
markups-json
branch
from
07f3f0d
to
005eb4a
Compare
|
I'll merge this now. @Sunderlandkyl when you have time please have a look and if you have comments I'll fix them in a separate commit. |
|
Thanks @lassoan, it looks good to me! |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows custom markup classes (implemented outside Slicer core) to store additional properties in the markups file in JSON.
vtkMRMLMarkupsJsonElement, vtkMRMLMarkupsJsonReader, and vtkMRMLMarkupsJsonWriter provide a simple JSON reading/writing interface without exposing the internal RapidJSON implementation.
This is required for example for this extension to build on Windows and macOS: https://github.com/chir-set/SlicerExtraMarkups