BUG: Do not display volume rendering if volume is under non-linear transform #7065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansform This commit just hides the volume and logs a message if a non-linearly transformed volume is attempted to be displayed using volume rendering. This is a partial fix, as it would be better if the user was warned on the GUI in advance that the volume will not be displayed; and it would be even better to allow correct display of the volume regardless of what transform it is under. Still, this fix is useful as it prevents a volume from appearing in incorrect position. see Slicer#6648
pieper
approved these changes
Jul 4, 2023
|
Thanks for the review. Implementing hardening internally would be better, but it would be a bit more work (we would need to expose the hardening API in a way that it could be used without modifying the existing node or creating a new node; we would also need to ensure that the resampling is done automatically when the volume or transform is changed, and not recomputed unnecessarily). |
|
I was also wondering if we can make a workaround recipe for this using the CLI autoexecute feature with one of the resampling CLIs. |
|
Good idea. We could work on it next time somebody asks for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit just hides the volume and logs a message if a non-linearly transformed volume is attempted to be displayed using volume rendering.
This is a partial fix, as it would be better if the user was warned on the GUI in advance that the volume will not be displayed; and it would be even better to allow correct display of the volume regardless of what transform it is under. Still, this fix is useful as it prevents a volume from appearing in incorrect position.
see #6648