Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Load DICOM files using DICOM module by default #7077

Merged
merged 1 commit into from Jul 10, 2023

Conversation

lassoan
Copy link
Contributor

@lassoan lassoan commented Jul 9, 2023

Drag-and-dropping a DICOM file made Slicer use ITK DICOM reader, which often did not load the data correctly.

This commit adds a new "DICOM import" reader type, which is selected by default for DICOM files. This reader imports the files into the Slicer DICOM database and switches to the DICOM module.

The workaround of interpreting all files as DICOM by default while in DICOM module has now been removed. "Add data" window is brought up when loading a file, regardless of what is the active module. The workaround surprised users when they could not load non-DICOM data while they were in DICOM module.

If a user wants to read the DICOM file using ITK reader, it is possible by changing "Description" in the "Add data" module to "Volume".

fixes #5726

Drag-and-dropping a DICOM file made Slicer use ITK DICOM reader, which often did not load the data correctly.

This commit adds a new "DICOM import" reader type, which is selected by default for DICOM files. This reader imports the files into the Slicer DICOM database and switches to the DICOM module.

The workaround of interpreting all files as DICOM by default while in DICOM module has now been removed. "Add data" window is brought up when loading a file, regardless of what is the active module. The workaround surprised users when they could not load non-DICOM data while they were in DICOM module.

If a user wants to read the DICOM file using ITK reader, it is possible by changing "Description" in the "Add data" module to "Volume".

fixes Slicer#5726
@lassoan lassoan added this to the Slicer 5.3 milestone Jul 9, 2023
@lassoan lassoan requested a review from pieper July 9, 2023 19:43
@lassoan lassoan self-assigned this Jul 9, 2023
Copy link
Member

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I have often been confused that data drops were rejected when the dicom module was active, and similarly there's been confusion about the difference between Add Data and the DICOM module. This nicely fixes both.

@pieper pieper merged commit ff1ba16 into Slicer:main Jul 10, 2023
5 checks passed
@lassoan lassoan deleted the load-dicom-using-dicom-module branch July 10, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Disable DICOM import from "Add data" dialog
2 participants