Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] COMP: Fix extension packaging on macOS accounting for synthetic firmlink #7182

Merged
merged 1 commit into from
Aug 21, 2023
Merged

[5.4] COMP: Fix extension packaging on macOS accounting for synthetic firmlink #7182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions CMake/SlicerExtensionCPack.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,14 @@ if(APPLE)
set(EXTENSION_SUPERBUILD_DIR ${EXTENSION_SUPERBUILD_BINARY_DIR})
get_filename_component(Slicer_SUPERBUILD_DIR ${Slicer_DIR}/.. ABSOLUTE)

# If any, resolve synthetic firmlink (e.g from "/D/P/A" to "/Users/svc-dashboard/D/P/A")
#
# Since the output of "otool -L" reports paths with synthetic firmlinks resolved
# (see GetPrerequisitesWithRPath), we are using REAL_PATH below to also resolve
# Slicer_SUPERBUILD_DIR and ensure that the test in "SlicerExtensionCPackBundleFixup.cmake.in"
# checking if "${key}_ITEM" is a library built in Slicer itself work as expected.
file(REAL_PATH ${Slicer_SUPERBUILD_DIR} Slicer_SUPERBUILD_DIR)

#------------------------------------------------------------------------------
# <ExtensionName>_FIXUP_BUNDLE_LIBRARY_DIRECTORIES
#------------------------------------------------------------------------------
Expand Down