PERF: Improve performance when removing segmentation from SH tree #7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
reviewed
Sep 29, 2023
| @@ -1119,6 +1119,9 @@ bool vtkSubjectHierarchyItem::RemoveChild(vtkSubjectHierarchyItem* item) | |||
| // as they represent the item's data node's content), then remove virtual branch | |||
| if (removedItem->IsVirtualBranchParent()) | |||
| { | |||
| // If the item has many virtual children, then it may invoke a large number of events. | |||
| // To avoid this, block modified events on the data node until all of the children are removed. | |||
| MRMLNodeModifyBlocker blocker(removedItem->DataNode); | |||
| removedItem->RemoveAllChildren(); | |||
There was a problem hiding this comment.
In addition of tkSubjectHierarchyItem::RemoveChild(vtkSubjectHierarchyItem* item), should this be done in these functions as well where RemoveAllChildren is also called?
vtkSubjectHierarchyItem::DeepCopy(vtkSubjectHierarchyItem* item, bool copyChildren/*=true*/)vtkSubjectHierarchyItem::~vtkSubjectHierarchyItem()vtkSubjectHierarchyItem::RemoveChild(vtkIdType itemID)vtkMRMLSubjectHierarchyNode::Copy(vtkMRMLNode *anode)
Even better, should we consider updating RemoveAllChildren to systematically block the event ?
There was a problem hiding this comment.
That's a good point, the same performance issue could occur with any of those functions.
I've moved the MRMLNodeModifyBlocker into RemoveAllChildren.
Sunderlandkyl
force-pushed
the
sh_segmentation_removal
branch
from
0c47b18
to
8d41483
Compare
jcfr
reviewed
Sep 29, 2023
When removing a vtkMRMLSegmentationNode using the SubjectHierarchy tree, all of the virtual children would be removing before the segmentation. This caused a large number of updates in various segmentation widgets as all of the widgets were regenerated when each of the segments were removed from the segmentation node. This commit improves performance by blocking modification events on the segmentation node (or any other node with virtual children), until all of the children have been removed. Rendering is also blocked during the item removal to prevent unnecessary updates of the views.
Sunderlandkyl
force-pushed
the
sh_segmentation_removal
branch
from
8d41483
to
f699724
Compare
jcfr
approved these changes
Sep 29, 2023
lassoan
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing a vtkMRMLSegmentationNode using the SubjectHierarchy tree, all of the virtual children would be removing before the segmentation. This caused a large number of updates in various segmentation widgets as all of the widgets were regenerated when each of the segments were removed from the segmentation node.
This commit improves performance by blocking modification events on the segmentation node (or any other node with virtual children), until all of the children have been removed. Rendering is also blocked during the item removal to prevent unnecessary updates of the views.