Two small fixes #7265
Merged
Two small fixes #7265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieper
requested changes
Oct 9, 2023
| * @brief Median Filter | ||
| * | ||
| * vtkImageMaskedMedian3D is a modified a Median filter that works the same way as | ||
| * vtkImageMaskedMedian3D filter except that it ignores 0 values. It can be |
There was a problem hiding this comment.
Suggested change
| * vtkImageMaskedMedian3D filter except that it ignores 0 values. It can be | |
| * vtkImageMedian3D filter except that it ignores 0 values. It can be |
There was a problem hiding this comment.
There was not a lot of repeated code (very small filter) but I've submitted a pull request to VTK instead - see Slicer/VTK#44 and https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10588
This fixes a minor bug in a feature introduced a few days ago.
lassoan
force-pushed
the
add-masked-mdedian-filter
branch
from
f25249b
to
206634c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains small fixes, see details in the commits. Do not squash merge.
Add masked median filter needed for RGBA volume generation - see Slicer/VTK#43.moved masked median filter to VTK (Merge Slicer/VTK#44)