Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix SubjectHierarchyGenericSelfTest #7289

Merged
merged 1 commit into from Oct 18, 2023
Merged

BUG: Fix SubjectHierarchyGenericSelfTest #7289

merged 1 commit into from Oct 18, 2023

Conversation

cpinter
Copy link
Member

@cpinter cpinter commented Oct 18, 2023

  • The test assumed incorrect shown item count including the empty folder (which flag is enabled by default), expected item counts has been fixed
  • Add test for the showEmptyHierarchyItems flag, which has not been tested until now

Re #7288

@cpinter cpinter requested a review from jcfr October 18, 2023 14:42
@jcfr
Copy link
Member

jcfr commented Oct 18, 2023 •
edited

Thanks for the PR, I further tweaked by generalizing testAttributeFilters to accept a showEmptyHierarchyItems argment.

If that looks good, I will squash the commit.

@jcfr jcfr linked an issue Oct 18, 2023 that may be closed by this pull request
Fix py_SubjectHierarchyGenericSelfTest test #7288
Closed
@cpinter
Copy link
Member Author

cpinter commented Oct 18, 2023

Sure, looks good, thank you!

@cpinter @jcfr
BUG: Fix SubjectHierarchyGenericSelfTest
4c694f9 
Follow-up of 5f7ae8d (ENH: Improve empty folder visibility logic):

- Update test to consider that empty folders are now visible by default.
- Update testAttributeFilters to check for showEmptyHierarchyItems set
  to False and True.

Fixes Slicer#7288

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
@jcfr jcfr force-pushed the 7288-fix-py_subjecthierarchygenericselftest branch from 4bf2f13 to 4c694f9 Compare October 18, 2023 16:52
jcfr
jcfr approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local testing on Ubuntu confirmed that the test is now passing.

@jcfr jcfr enabled auto-merge (rebase) October 18, 2023 16:53
@jcfr jcfr merged commit d472770 into Slicer:main Oct 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfr jcfr jcfr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix py_SubjectHierarchyGenericSelfTest test
2 participants
@cpinter @jcfr