Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Update CTK to adjust the size of the delete DICOM object dialog #7317

Merged
merged 1 commit into from Oct 30, 2023

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Oct 30, 2023

When deleting many patients (or studies or series) it can occur that the confirmation dialog that is created with all the deleted object names is taller than the screen height, so the buttons are cut off and not available.

This ensures that the said dialog cannot be higher than the DICOM browser.

List of CTK changes:

$ git shortlog 5657c58a7..b9ef9b8a --no-merges
Csaba Pinter (1):
      BUG: Make sure the delete DICOM object dialog is not too tall

When deleting many patients (or studies or series) it can occur that
the confirmation dialog that is created with all the deleted object
names is taller than the screen height, so the buttons are cut off
and not available.

This ensures that the said dialog cannot be higher than the DICOM browser.

List of CTK changes:

$ git shortlog 5657c58a7..b9ef9b8a --no-merges
Csaba Pinter (1):
      BUG: Make sure the delete DICOM object dialog is not too tall

Co-authored-by: Csaba Pinter <pinter.csaba@gmail.com>
@pieper
Copy link
Member

pieper commented Oct 30, 2023

For reference: commontk/CTK@b9ef9b8

@jcfr jcfr merged commit e8ddfb3 into Slicer:main Oct 30, 2023
5 checks passed
@jcfr jcfr deleted the update-ctk-adjust-dicom-delete-dialog branch October 30, 2023 17:02
@jcfr jcfr added the backport:5.x Identify pull request expected to be backported to the current 5.x release branch. label Nov 5, 2023
@jcfr jcfr removed the backport:5.x Identify pull request expected to be backported to the current 5.x release branch. label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants