Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update DICOMUtils loadPatient API to handle messages and progressCallback #7330

Merged
merged 1 commit into from Nov 2, 2023

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Nov 1, 2023

Originally posted by @lassoan in #7270 (review)

[...] I agree that it can be useful to expose messages and progressCallback arguments at higher-level functions, too. I would prefer to explicitly specify these arguments, as it would make the API more clear (and 2 extra arguments are not too many and I don't expect that loadLoadables will have many new options in the future).

cc: @marcus-wirtz-snkeos


This pull request was created to include the changes originally included through this pull-requests:

For the sake of having a clean history and considering the updated main branch has not been referenced externally, main was forced push to b050d39

@jcfr jcfr force-pushed the feature/progressbar_available-updated branch from af1bb4a to 7ada5e7 Compare November 1, 2023 18:23
@jcfr jcfr changed the title ENH: Propagate args / kwargs to loadLoadables ENH: Update DICOMUtils loadPatient API to handle messages and progressCallback Nov 1, 2023
@jcfr jcfr requested a review from lassoan November 1, 2023 22:40
@jcfr jcfr force-pushed the feature/progressbar_available-updated branch from 7ada5e7 to 0f62d3e Compare November 1, 2023 22:43
@jcfr
Copy link
Member Author

jcfr commented Nov 2, 2023

@lassoan @jamesobutler @pieper Since this change was already approved in the original pull request, review should be straightforward. 🙏

@jcfr jcfr merged commit 186a8bf into Slicer:main Nov 2, 2023
5 checks passed
@jcfr jcfr deleted the feature/progressbar_available-updated branch November 2, 2023 01:45
@jcfr jcfr added the backport:5.x Identify pull request expected to be backported to the current 5.x release branch. label Nov 5, 2023
@jcfr jcfr removed the backport:5.x Identify pull request expected to be backported to the current 5.x release branch. label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants