Improve scripted classes readability renaming setPythonSource parameter and associated internal variable #7352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested-by: Steve Pieper <pieper@isomics.com>
…able Follow-up previous commit renaming internal variable from PythonSource to PythonSourceFilePath. This more accurately conveys the variable's purpose, avoiding any ambiguity between "python code" and "python script".
pieper
approved these changes
Nov 6, 2023
jcfr
deleted the
improve-scripted-class-readability-renaming-arg-and-ivar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes implemented following the comment of @pieper in #7351 (comment).
This more accurately conveys the variable's purpose, avoiding any ambiguity between "python code" and "python script".
Improve
setPythonSourceAPI readability renaming parameter fromnewPythonSourcetofilePathImprove code readability renaming scripted class internal variable from
PythonSourcetoPythonSourceFilePath