ENH: Use "Use this curve" instead of "Create flythrough path" as button text #7435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
approved these changes
Nov 27, 2023
jcfr
changed the title
jcfr
added
Type: Enhancement
jcfr
added
the
backport:5.x
jcfr
removed
the
backport:5.x
jcfr
pushed a commit
that referenced
this pull request
Dec 11, 2023
(cherry picked from commit 5661f8e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects that the purpose of the button is to indicate to the Endoscopy module which curve the flythrough should be along. Although the button does also trigger computations for the flythrough this is a behind-the-scenes decision that could later be changed. In particular, modifications of the curve cause re-calculations as necessary without the user having to click the button again.