Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Endoscopy module UI self-discovery #7436

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Improve Endoscopy module UI self-discovery #7436

merged 2 commits into from
Nov 28, 2023

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Nov 28, 2023

This pull request introduces the following improvements:

  • All UI elements in the Endoscopy module now have informative tooltips.
  • The view angle slider setting is now suffixed with "degree".

jcfr and others added 2 commits November 28, 2023 00:40
@jcfr @Leengit
ENH: Improve self-discovery of Endoscopy UI by providing all tooltips
d970279 
Co-authored-by: Lee Newberg <lee.newberg@kitware.com>
@jcfr @Leengit
ENH: Clarify Endoscopy view angle slider setting by suffixing with "d…
fe26dfa 
…egree"

Co-authored-by: Lee Newberg <lee.newberg@kitware.com>
@jcfr jcfr requested a review from Leengit November 28, 2023 05:40
Leengit
Leengit approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Leengit Leengit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jcfr jcfr merged commit 3476a2f into Slicer:main Nov 28, 2023
5 checks passed
@jcfr jcfr deleted the endoscopy-tooltip branch November 28, 2023 13:58
@jcfr jcfr added Type: Enhancement Improvement to functionality Type: Documentation Issues regarding documentation labels Nov 28, 2023
@jcfr jcfr mentioned this pull request Dec 11, 2023
Closed
18 tasks
@jcfr jcfr added the backport:5.x Identify pull request expected to be backported to the current 5.x release branch. label Dec 11, 2023
@jcfr jcfr mentioned this pull request Dec 11, 2023
Merged
@jcfr jcfr removed the backport:5.x Identify pull request expected to be backported to the current 5.x release branch. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leengit Leengit Leengit approved these changes

Assignees
No one assigned
Labels
Type: Documentation Issues regarding documentation Type: Enhancement Improvement to functionality
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcfr @Leengit