BUG: Update VTK to to fix vtkSMPToolsAPI static initialization order issue #7453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The topic has been locally checkout on our Linux, macOS and Windows factories. Once build and tests are confirmed to be working, I will follow up. |
jcfr
added
the
backport:5.x
|
Update related to build and testing of this pull request:
On the three factories the branch corresponding to this pull request was checked out and the Slicer project rebuilt from the top-level. "factory" describes the build machine used to build and test the official Slicer packages. macOS testingLinux testingThis is the only platform where I explicitly indicate the branch is checked out and the project rebuilt. then Windows testing⏳ In progress... |
|
|
I am further improving the VTK patch to also ensures the statics used in the each backend are properly handled. |
…issue This addresses a crash related to the static initialization order 'fiasco' in vtkSMPToolsAPI. It ensures proper deletion of the vtkSMPToolsAPI singleton once the last translation unit referencing it has been unloaded. It also ensures backend-specific statics are properly initialized. when the first translation unit is loaded. This update ensures that the SMP backend is cleaned up at the appropriate time, fixing the following macOS tests that started to fail following commit 28dca75 (ENH: Enable TBB as the default VTK SMP implementation on all platforms): * `py_nomainwindow_SegmentationWidgetsTest1` * `py_sceneImport2428` * `py_SegmentStatistics` * `py_UtilTest` List of changes: $ git shortlog 4bfb0f049a..46201478cd --no-merges Jean-Christophe Fillion-Robin (3): [Backport MR-10751] BUG: Resolve crash by fixing vtkSMPToolsAPI static initialization order issue [Backport MR-10751] ENH: Simplify vtkSMPToolsAPIInitialize managing pointer and counter locally [Backport MR-10751] BUG: Resolve crash by fixing initialization of backend-specific statics
jcfr
force-pushed
the
backport-vtk-fix-vtkSMPToolsAPI-crash-ensuring-proper-static-initialization
branch
from
c29e59a
to
650cae1
Compare
|
Et voila, after updating Footnotes |
jcfr
deleted the
backport-vtk-fix-vtkSMPToolsAPI-crash-ensuring-proper-static-initialization
branch
|
Manually re-triggered nightly builds look good 🎉
|
This was referenced Dec 11, 2023
jcfr
removed
the
backport:5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a crash related to the static initialization order 'fiasco' in
vtkSMPToolsAPI. It ensures proper deletion of thevtkSMPToolsAPIsingleton once the last translation unit referencing it has been unloaded.This update ensures that the SMP backend is cleaned up at the appropriate time, fixing the following macOS tests that started to fail following commit 28dca75 (ENH: Enable TBB as the default VTK SMP implementation on all platforms):
py_nomainwindow_SegmentationWidgetsTest1py_sceneImport2428py_SegmentStatisticspy_UtilTestList of changes:
Related