Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Streamline Endoscopy UX removing "Use this curve" button #7462

Merged
merged 31 commits into from
Dec 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
3385e84
ENH: Use "Use this curve" instead of "Create flythrough path" (#7435)
Leengit Nov 27, 2023
a28b131
BUG: Fix rebuild of Endoscopy flythrough when modifying the input curve
Leengit Nov 27, 2023
a31aea0
ENH: Simplify Endoscopy math helper functions API to only return value
jcfr Nov 27, 2023
bbc0047
BUG: Remove invalid and unused quaternion functions from EndoscopyLogic
jcfr Nov 27, 2023
174e475
ENH: Simplify Endoscopy API removing wrapping of relative orientation…
jcfr Nov 27, 2023
fca3a84
ENH: Simplify initialization of vtkQuaternion in EndoscopyLogic
jcfr Nov 27, 2023
3e5a7f8
ENH: Improve self-discovery of Endoscopy UI by providing all tooltips
jcfr Nov 28, 2023
6fb63f3
ENH: Clarify Endoscopy view angle slider setting by suffixing with "d…
jcfr Nov 28, 2023
2f15be1
BUG: Recompute EndoscopyLogic fields immediately instead of lazily
Leengit Nov 28, 2023
f64de65
ENH: Simplify Endoscopy relative orientation API converting to static…
jcfr Nov 27, 2023
8d29e62
DOC: Update Endoscopy module comment describing the interpolation method
jcfr Nov 27, 2023
0dcb1fe
DOC: Clarify EndoscopyLogic API fixing setControlPoints type annotation
jcfr Dec 6, 2023
9b119bc
ENH: Simplify EndoscopyLogic API to set and get input curve CameraOri…
jcfr Nov 29, 2023
1381812
ENH: Simplify EndoscopyLogic API introducing removeOrientationAtIndex
jcfr Nov 29, 2023
b1b97c4
ENH: Simplify EndoscopyLogic API introducing saveOrientationAtIndex
jcfr Nov 29, 2023
c330af7
ENH: Simplify EndoscopyLogic API introducing getNumberOfControlPoints
jcfr Nov 29, 2023
ad4cf42
ENH: Simplify EndoscopyLogic API introducing updateCameraFromOrientat…
jcfr Nov 29, 2023
d1222b0
ENH: Relocate Endoscopy widget update into updateWidgetFromMRML
jcfr Nov 30, 2023
38d0fa5
ENH: Remove unneeded instance variable related to Endoscopy model export
jcfr Nov 30, 2023
7536b14
ENH: Simplify EndoscopyLogic API for managing cursor and transform nodes
jcfr Nov 27, 2023
91881ac
ENH: Rename EndoscopyLogic API to interpolate orientation of control …
jcfr Nov 30, 2023
b6f5ed8
ENH: Rename EndoscopyLogic API to update control points based on inpu…
jcfr Nov 30, 2023
48e8ab7
ENH: Simplify EndoscopyLogic API by implicitly interpolating orientat…
jcfr Dec 5, 2023
9a14c39
ENH: Simplify EndoscopyLogic API introducing input curve "Camera" ref…
jcfr Dec 5, 2023
fedac15
ENH: Streamline Endoscopy UX removing "Use this curve" button
jcfr Nov 30, 2023
65f6838
DOC: Update EndoscopyLogic class docstring
jcfr Dec 6, 2023
8b11199
ENH: Update EndoscopyLogic to support saving camera view angle
jcfr Dec 6, 2023
e87e82a
BUG: Update EndoscopyLogic to Fix Camera Property Handling
jcfr Dec 7, 2023
8cc4676
BUG: Consistently handle First/Back/Next/Last keyframe in Endoscopy
jcfr Dec 8, 2023
9f93fcc
ENH: Update EndoscopyLogic API for retrieving first/previous/next/las…
jcfr Dec 8, 2023
c427b52
ENH: Improve Endoscopy usability updating status of keyframe navigati…
jcfr Dec 8, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions Docs/user_guide/modules/endoscopy.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ Selects the camera and curve to be manipulated.

- **Camera**: The camera used for the flythrough.
- **Curve to modify**: The curve defining the flythrough path control points.
- **Create flythrough path**: Press to generate the flythrough path corresponding to the selected curve and camera.

### Flythrough

Expand All @@ -28,7 +27,7 @@ Controls the animation.
- **View Angle**: Field of view of the camera. The default value of 30 degrees approximates normal camera lenses. Larger numbers, such as 110 or 120 degrees approximate the wide angle lenses often used in endoscopy viewing systems.
- **Save keyframe orientation** / **Update keyframe orientation**: Press to indicate that a flythrough frame is a keyframe and that you have selected your desired camera orientation for this keyframe in the first-person, 3D viewing pane. If you wish to update the orientation for a keyframe, use the Frame, First, Back, Next, or Last buttons to go to the frame, adjust the camera orientation, and hit this button again.
- **Delete keyframe orientation**: Discard the camera orientation associated with the selected keyframe.
- **First**: PRess to go to the lowest-numbered keyframe.
- **First**: Press to go to the lowest-numbered keyframe.
- **Back**: Press to move backwards through the flythrough to the nearest keyframe.
- **Next**: Press to move forwards through the flythrough to the nearest keyframe.
- **Last**: Press to go to the highest-numbered keyframe
Expand Down