Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.6] BUG: Restore maximization of view on double click event #7463

Merged
merged 3 commits into from Dec 11, 2023
Merged

[5.6] BUG: Restore maximization of view on double click event #7463

merged 3 commits into from Dec 11, 2023

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Dec 11, 2023

Backports changes originally contributed to main through the following pull requests:

@jcfr
BUG: Restore maximization of view on double click event
2b2ce44 
This commit fixes a regression introduced in 1cc3b2c (ENH: Improve Event
Delegation in qMRMLThreeDView and qMRMLSliceView) adding missing observers.

(cherry picked from commit eda9655)
@jcfr
DOC: Fix typo in "MRML Events and Observers" section
8f86a41 
(cherry picked from commit e583ecd)
@jcfr
BUG: Add missing interactorStyle observers for start/end pinch/rotate…
fe64c90 
…/pan

This commit fixes a regression introduced in 1cc3b2c (ENH: Improve Event
Delegation in qMRMLThreeDView and qMRMLSliceView) adding missing observers.

(cherry picked from commit 017f277)
@jcfr jcfr requested a review from pieper December 11, 2023 19:59
@jcfr jcfr mentioned this pull request Dec 11, 2023
Closed
18 tasks
pieper
pieper approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcfr jcfr merged commit 0d0ed04 into Slicer:5.6 Dec 11, 2023
5 checks passed
@jcfr jcfr deleted the 5.6-backport/fix-interactor-style-event-observation-regression branch December 11, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieper pieper pieper approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcfr @pieper