[5.6] ENH: Disable pip version check #7466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the quarterly update cycle of python packages bundled into Slicer. To mitigate unnecessary console clutter caused by the pip version check, the variable `PIP_DISABLE_PIP_VERSION_CHECK` is set, suppressing warnings such as: ```bash $ PythonSlicer -m pip list [...] [notice] A new release of pip is available: X.Y.Z -> Z'.Y'.Z' [notice] To update, run: pip install --upgrade pip ``` To ensure that `the PIP_DISABLE_PIP_VERSION_CHECK` environment variable is undefined when Slicer is built against a system or external Python installation, this variable is set only in the pip external project. This also addresses an issue introduced in 028fb31 (COMP: Update python packages to latest) where the pip version was updated from `23.1.2` to `23.3`. This resulted in the following warning message instead of the expected update notification: ```bash WARNING: There was an error checking the latest version of pip. ``` For additional details about `PIP_DISABLE_PIP_VERSION_CHECK`: * https://pip.pypa.io/en/stable/cli/pip/#cmdoption-disable-pip-version-check * https://pip.pypa.io/en/stable/topics/configuration/#environment-variables (cherry picked from commit 2cf6f14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports changes originally contributed to
mainthrough the following pull requests:This commit addresses the quarterly update cycle of python packages bundled into Slicer. To mitigate unnecessary console clutter caused by the pip version check, the variable
PIP_DISABLE_PIP_VERSION_CHECKis set, suppressing warnings such as:To ensure that
the PIP_DISABLE_PIP_VERSION_CHECKenvironment variable is undefined when Slicer is built against a system or external Python installation, this variable is set only in the pip external project.This also addresses an issue introduced in 028fb31 (COMP: Update python packages to latest) where the pip version was updated from
23.1.2to23.3. This resulted in the following warning message instead of the expected update notification:For additional details about
PIP_DISABLE_PIP_VERSION_CHECK:(cherry picked from commit 2cf6f14)