Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Update data probe module to avoid resizing issues #7541

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hannah-morilak
Copy link
Contributor

This PR updates the Data Probe module to stop hiding/showing elements to avoid awkward resizing.

ZoomySlicerad

This is the look after this PR:

ZoomySlicer

cc: @jamesobutler

@lassoan
Copy link
Contributor

lassoan commented Jan 13, 2024

I agree that the changing window size is not ideal. However, taking away vertical space from the module panel just to show useless information (S None) is not ideal either. Especially because it is almost impossible to know what is the maximum size required. Printing the name of all segments visible at the current mouse position may require several lines of text. How many would you allocate?

image

Does the changing window size cause any specific problems for you? Can you think of other solutions than preallocating a quite large space for the widget (which would be unusued most of the time)?

Usually we only have a background volume and allocating 2 empty lines for foreground and label is already a pretty bad waste of valuable vertical space in the module panel. We should try to use the space more efficiently rather than making the situation even worse by allocating more blank space.

@lassoan
Copy link
Contributor

lassoan commented Jan 13, 2024

Maybe we could revisit showing annotations in the slice view. The data probe was added because rendering of text slowed down view interactions too much. But maybe text rendering speed and generally computer speed has been improved enough over the years that it could be feasible to show all these information in corner annotations. Could you experiment with this? The DataProbe module already manages corner annotations (SliceViewAnnotations.py), so you would just need to tweak the module a bit to change what information is included in corner annotations.

@pieper
Copy link
Member

pieper commented Jan 13, 2024

I like the idea of moving the segment names into the slice view somewhere, perhaps as a tooltip.

@lassoan lassoan added the Status: Awaiting Response ⏳ Waiting for a response/more information label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting Response ⏳ Waiting for a response/more information
Development

Successfully merging this pull request may close these issues.

None yet

3 participants