Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update pre-commit hooks #7654

Merged
merged 1 commit into from Apr 11, 2024
Merged

ENH: Update pre-commit hooks #7654

merged 1 commit into from Apr 11, 2024

Conversation

slicer-app[bot]
Copy link
Contributor

@slicer-app slicer-app bot commented Mar 22, 2024

@jcfr
Copy link
Member

jcfr commented Mar 22, 2024

Before we integrate, I will look into fixing the link generation.

Cc: @jamesobutler

@slicer-app slicer-app bot force-pushed the update/pre-commit-hooks branch 3 times, most recently from c9e26d3 to d0b9e2d Compare March 29, 2024 00:28
@slicer-app slicer-app bot force-pushed the update/pre-commit-hooks branch 7 times, most recently from 9571cbe to c6ddbc9 Compare April 8, 2024 00:29
@slicer-app slicer-app bot force-pushed the update/pre-commit-hooks branch 2 times, most recently from 4a87142 to a52831a Compare April 11, 2024 00:28
@jcfr
Copy link
Member

jcfr commented Apr 11, 2024

Before we integrate, I will look into fixing the link generation.

@jamesobutler After integrating #7688, I will trigger the workflow and this pull request description should be the expected one.

@jamesobutler
Copy link
Contributor

This pull-request was auto-generated by the pre-commit-autoupdate GitHub action workflow.

@jcfr Actually this link appears to not be valid. Should be pointing to main such as https://github.com/Slicer/Slicer/blob/main/.github/workflows/pre-commit-autoupdate.yml?

@jcfr
Copy link
Member

jcfr commented Apr 11, 2024

re: Actually this link appears to not be valid. Should be pointing to main

Good catch. This should be addressed in #7690

updates:
- [pre-commit/pre-commit-hooks: v4.5.0 -> v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)
- [astral-sh/ruff-pre-commit: v0.3.3 -> v0.3.6](astral-sh/ruff-pre-commit@v0.3.3...v0.3.6)
- [asottile/pyupgrade: v3.15.1 -> v3.15.2](asottile/pyupgrade@v3.15.1...v3.15.2)
@jamesobutler jamesobutler enabled auto-merge (rebase) April 11, 2024 17:51
@jamesobutler jamesobutler merged commit 56f3f1b into main Apr 11, 2024
6 checks passed
@jamesobutler jamesobutler deleted the update/pre-commit-hooks branch April 11, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants