Show warning window if data loss occurs when saving to tiff #7655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a language was specified for updating translations and no translation file was found for that language then a new translation file was generated for en-US language. This commit changes this to generate translation file for the specified language.
lassoan
force-pushed
the
dev/tiff-save-warning-window
branch
from
1f85b13
to
450a933
Compare
lassoan
changed the title
lassoan
force-pushed
the
dev/tiff-save-warning-window
branch
from
450a933
to
534883a
Compare
pieper
previously approved these changes
Mar 22, 2024
| if ((vtksys::SystemTools::StringEndsWith(lowerCaseFileName, ".tiff") || | ||
| vtksys::SystemTools::StringEndsWith(lowerCaseFileName, ".tif"))) | ||
| { | ||
| // Display warning if saving VTK file with non-LPS axes (VTK cannot store axis directions) |
There was a problem hiding this comment.
Comment should refer to tiff not VTK
There was a problem hiding this comment.
Good catch, I will fix it
Adds warning for TIFF file format saving. Prevents potential data loss. Made translatable all messages that may be relevant to users. see Slicer#7588 Co-authored-by: Andras Lasso <lasso@queensu.ca>
lassoan
force-pushed
the
dev/tiff-save-warning-window
branch
from
ce8d0e3
to
c33335c
Compare
|
@pieper please have a look and approve if it looks good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request supersedes #7614 by @aramSofthenge