Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add DICOM patcher rule to fix compressed ultrasound discolorization #7656

Merged

Conversation

lassoan
Copy link
Contributor

@lassoan lassoan commented Mar 22, 2024

Photometric intepretation field of compressed ultrasound images was ambiguous before DICOM CP156 (https://dicom.nema.org/medical/dicom/Final/cp156_ft.pdf) and there are DICOM images in the wild that contain photometric interpretation value (RGB) that is inconsistent with the compressed transfer syntax (JPEG). See https://groups.google.com/g/comp.protocols.dicom/c/EPkbFOMBOhE for more details.

The new DICOM patcher rule modifies RGB photometric interpretation to YBR_FULL_422 if the transfer syntax of the image is JPEG, because JPEG compression is practically always used with YBR_FULL_422.

@lassoan lassoan added this to the Slicer 5.7 milestone Mar 22, 2024
@lassoan lassoan requested a review from pieper March 22, 2024 16:04
@lassoan lassoan self-assigned this Mar 22, 2024
Photometric intepretation field of compressed ultrasound images was ambiguous before DICOM CP156
(https://dicom.nema.org/medical/dicom/Final/cp156_ft.pdf) and there are DICOM images in the wild
that contain photometric interpretation value (RGB) that is inconsistent with the compressed transfer syntax
(JPEG). See https://groups.google.com/g/comp.protocols.dicom/c/EPkbFOMBOhE for more details.

The new DICOM patcher rule modifies RGB photometric interpretation to YBR_FULL_422 if the transfer syntax
of the image is JPEG, because JPEG compression is practically always used with YBR_FULL_422.
@lassoan lassoan force-pushed the add-dicom-patcher-rule-for-compressed-ulrasound branch from a97a066 to e91cb00 Compare March 22, 2024 16:06
Copy link
Member

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pieper pieper merged commit 861bc7e into Slicer:main Mar 25, 2024
5 checks passed
@lassoan lassoan deleted the add-dicom-patcher-rule-for-compressed-ulrasound branch March 25, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants