ENH: Update Ruff configuration checking for numpy2 deprecation issues #7694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
reviewed
Apr 14, 2024
| @@ -26,6 +26,7 @@ select = [ | |||
| # "SIM", # flake8-simplify | |||
| "UP", # pyupgrade | |||
| "YTT", # flake8-2020 | |||
| "NPY201", # numpy2-deprecation | |||
There was a problem hiding this comment.
Since we are already specifying NPY above, I think this rule is already enabled by default.
See https://docs.astral.sh/ruff/rules/#numpy-specific-rules-npy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.astral.sh/ruff/rules/numpy2-deprecation/
To prep for users potentially using Numpy 2, this runs a numpy2 deprecation check to avoid any incompatibilities. It appears that Slicer's numpy usage is already compatible, but this additional check makes sure that continues.