Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to work with Slicer 4.13 preview releases. #46

Merged
merged 7 commits into from
Oct 8, 2021

Conversation

dazzag24
Copy link
Contributor

@dazzag24 dazzag24 commented Oct 8, 2021

install.sh

  • now works with both 4.11 and 4.13 versions where the metadata format and download url format have changed.
  • Change to use single quote escaping - makes indented python easier to read and edit

Dockerfile
-Updated SLICER_DOWNLOAD_URL for the current 4.13 preview release

  • Simplifies the curl and extraction - no need to match SLICER_ARCHIVE value to whatever the download server decides to return.
  • Added notebook jupyterhub jupyterlab modules to pip install in preparation for use on Jupyterhub
  • Remove unnecessary apt-get steps (move ca-certs to top with other installs)

Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thank you! I've just added a few trivial comments.

It would be great if you could send a link to an image that you have built with the latest Slicer Preview Release so that I can give it a try.

slicer-notebook/Dockerfile Outdated Show resolved Hide resolved
slicer-notebook/Dockerfile Outdated Show resolved Hide resolved
slicer-notebook/install.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it all looks good!

@lassoan lassoan merged commit c9f0f28 into Slicer:master Oct 8, 2021
@lassoan
Copy link
Contributor

lassoan commented Oct 8, 2021

This is merged now.

Please provide a link for a built image for the latest Slicer Preview Release so that I can give it a quick try.
Also let us know about the results of your experiments with JupyterLab and JupyterHub.

Thank you for your contribution!

@dazzag24
Copy link
Contributor Author

dazzag24 commented Oct 8, 2021 via email

@jcfr
Copy link
Member

jcfr commented Oct 8, 2021

Thanks @dazzag24 💯 and @lassoan , this is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants