Support installation (rebased) #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce GenerateCLP_INSTALL_CMAKE_DIR variable allowing to configure install location for "GenerateCLP.cmake" macro. * GenerateCLP_INSTALL_NO_DEVELOPMENT: Change default value from ON to OFF. This will ensure GenerateCLP macro and dependent files are installed by default. * GenerateCLPLauncher: - Update hardcoded location of ITK libraries. It was changed from "bin" to "lib" in ITKv4. - Update forward install dir to account for that fact both GenerateCLP and launcher are installed in the same directory. * Ensure following files are installed: - UseGenerateCLP.cmake - GenerateCLPConfig.cmake - GenerateCLP.cmake Co-authored-by: Nicole Aucoin <nicole@bwh.harvard.edu>
* Introduced "GenerateCLP-Install.cmake" script that is deleting the directory associated with CMAKE_INSTALL_PREFIX, and re-installing the files building the "install" target. * Introduced variable TEST_TREETYPE set to either "BuildTree" or "InstallTree". This variable allows to conditionally update the testing context in Configure, Build or Test steps associated with each examples. * For the "BuildTree" case, GenerateCLP_DIR is hardcoded in GenerateCLPTestPrerequisites whereas it is passed as test argument for the "InstallTree" case. Co-authored-by: Nicole Aucoin <nicole@bwh.harvard.edu>
Slicer#44 This will ensure running the tests will not delete files associated with the current CMAKE_INSTALL_PREFIX. Co-authored-by: Nicole Aucoin <nicole@bwh.harvard.edu>
jcfr
force-pushed
the
44-support-installation
branch
from
235305b
to
8d82e1a
Compare
|
|
@jcfr Confirmed that tests still fail even after rebasing on master branch: The following tests FAILED: |
|
@jcfr. 7 years since this opened, 3.5 years since comments were made. Is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.