Enable installation of vtkAddon #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 27, 2020 20:01
- Globbing of pattern "*.(h|txx)" does not seem to work. Globbing
pattern separated in two patterns "*.h" and "*.txx"
- Adding the ${PROJECT_NAME}_INSTALL_INCLUDE_DIR variable accounting
for the install path for development files
- Added new variables (${PROJECT_NAME}_PYTHON_MODULE_LIB_DIR and
${PROJECT_NAME}_INSTALL_PYTHON_LIB_DIR) accounting for paths
corresponding to python library modules files and python libraries files.
- Creation of vtkAddonInstallConfig.cmake.in templated file
- Configuration of install config file
- Installation of configuratio file
- Adding a new variable ${PROJECT_NAME}_INSTALL_CMAKE_DIR to account
for the project's 'installation cmake dir
jcfr
requested changes
Mar 27, 2020
|
One last change: -> |
This commit adds a copy of the CMake module vtkMacroKitPythonWrap based of Slicer/Slicer@78a71cd9a
|
@jcfr should we close this one ;) |
jcfr
reviewed
Apr 2, 2020
I will move forward with integrating this PR and will create an other issue to capture the fact the install tree should be relocatable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will enable the installation of vtkAddon.
In addition, bf189a1 adds the
vtkMacroKitPythonWrap.cmakefile needed to buildvtkAddonas a standalone project; this commit has been subject to discussion and might not be accepted in this pull as discussed in https://discourse.slicer.org/t/python-wrapping-on-the-new-external-vtkaddon/10826.The installation tree on linux with these changes is as follows:
given the following configuration: