COMP: fix several of the tests #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several of these tests relied on data previously provided by the Slicer core repository. Since Slicer moved to using the ExternalData processin CMake, these files were no longer available and these tests broke. This fix adds a few small testing data files to this repository and configures the tests to use them. Based on community discussion, another option could have been to use the ExternalData methodology in this extension. However since other extensions in the Slicer ecosystem do not use this method some new methods would need to be debugged. #130 With this commit, one file of 205k is added, which is minor and will be consistent with other data files already in the repository. It is used for testing CLIs. For the more extensive self tests data is downloaded so they do not need to be added to the repository.
ljod
requested changes
Sep 22, 2020
Good point, I'll change to use DATADIR consistently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of these tests relied on data previously provided
by the Slicer core repository. Since Slicer moved to
using the ExternalData processin CMake, these
files were no longer available and these tests broke.
This fix adds a few small testing data files to this repository
and configures the tests to use them.
Based on community discussion, another option could have been
to use the ExternalData methodology in this extension. However
since other extensions in the Slicer ecosystem do not use this
method some new methods would need to be debugged.
#130
With this commit, one file of 205k is added, which is
minor and will be consistent with other data files already
in the repository. It is used for testing CLIs. For the
more extensive self tests data is downloaded so they
do not need to be added to the repository.