Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix fiber bundle reader crash #208

Merged
merged 1 commit into from Dec 7, 2023

Conversation

lassoan
Copy link
Contributor

@lassoan lassoan commented Nov 9, 2023

No description provided.

@jhlegarreta
Copy link
Contributor

This is doing its job. The following tests are being fixed:

 10 - py_NsgPlanTracto (Failed)
 52 - py_TractographyExportPLY (Failed)
 54 - py_TractographyDownsample (Failed)

The remaining issues are related to the tract1 and FA nodes not being found on the scene, e.g.
https://github.com/SlicerDMRI/SlicerDMRI/actions/runs/7051030751/job/19193025928?pr=220

Related discussion:
https://discourse.slicer.org/t/fixing-extension-testing-failures/32584
#207

And the known issue of the measurement data:
#206

Copy link
Member

@ljod ljod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ljod ljod merged commit e164694 into SlicerDMRI:master Dec 7, 2023
0 of 2 checks passed
@ljod
Copy link
Member

ljod commented Dec 13, 2023

@lassoan Hi Andras! Thank you for this helpful commit! Fiber Bundles are loading now, but some of the display (specifically scalar values) seems to not be set up in the display pipeline. I described the steps to reproduce this with some example data in issue #227. Is there a change to the vtk API that we need to conform to? Or if you know what needs to be fixed, could you please let us know? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants