Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Ensure DicomUltrasoundPlugin sets DICOM.instanceUIDs #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Jul 10, 2023

No description provided.

@jcfr jcfr marked this pull request as draft July 10, 2023 20:54
@jcfr
Copy link
Contributor Author

jcfr commented Jul 10, 2023

I will have a follow-up commit also ensuring the DICOM.instanceUIDs is also set on the scalar volume node in the sequence.

@jcfr jcfr marked this pull request as ready for review July 10, 2023 20:59
@jcfr
Copy link
Contributor Author

jcfr commented Jul 10, 2023

Also save DICOM SOP instance UID into the master node so DICOM metadata
can be retrieved later from the proxy nodes if needed.

Co-authored-by: Andras Lasso <lasso@queensu.ca>
Comment on lines +577 to +583
# Save DICOM SOP instance UID into the master node so DICOM metadata can be retrieved later from
# the proxy nodes if needed
masterSequenceNode = sequenceBrowserNode.GetMasterSequenceNode()
masterSequenceNode.SetAttribute('DICOM.instanceUIDs', loadedNode.GetAttribute('DICOM.instanceUIDs'))

volumeNode = browserNode.GetProxyNode(loadedNode)
volumeNode.SetAttribute('DICOM.instanceUIDs', loadedNode.GetAttribute('DICOM.instanceUIDs'))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To follow-up on the commit originally posted by @lassoan in #28 (comment):

The sequence browser node can browse many different images, so in general the DICOM instance UIDs cannot be saved into that.

Instead, the attribute need to be set on the volume node in the sequence (and those attributes are copied to the proxy node).

I am not clear which approach was implied ?

  • Getting the master node
  • Or getting the proxy node

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to set the attribute of the data node that you set in the sequence.

Content of the data node in the sequence (including the attributes) are copied to the proxy node during replay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants