ENH: Generalize US 3D Reader to also support Image3dAPI through manifest #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit generalize the support for Image3dFileLoader so that the loading of the associated type library wrapper can be done if it was directly associated with the application using manifest. This removes the need for administrator privileges needed to explicitly register the loader using command like "regsvr32 Image3dLoaderGe.dll". At the time of this commit only the GE loader supports this approach.
|
How does this work in practice? Could you update the installation instructions with the simplified method? |
Will follow-up later. In a nutshell, this is the step |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit generalize the support for Image3dFileLoader so that the loading of the associated type library wrapper can be done if it was directly associated with the application using manifest.
This removes the need for administrator privileges needed to explicitly register the loader using command like "regsvr32 Image3dLoaderGe.dll".
At the time of this commit only the GE loader supports this approach.