Skip to content

Commit

Permalink
Update Pulsar to 1.2.1, making deps work properly
Browse files Browse the repository at this point in the history
  • Loading branch information
bonii-xx committed Mar 20, 2016
1 parent 637b830 commit 60dd10b
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,15 @@ public void registerPulse(Object pulse) {
configLoaded = true;
}

String id, description, deps;
String id, description, deps, pulseDeps;
boolean forced, enabled, defaultEnabled, missingDeps = false;

try {
Pulse p = pulse.getClass().getAnnotation(Pulse.class);
id = p.id();
description = p.description();
deps = p.modsRequired();
pulseDeps = p.pulsesRequired();
forced = p.forced();
enabled = p.defaultEnable();
defaultEnabled = p.defaultEnable();
Expand All @@ -151,7 +152,7 @@ public void registerPulse(Object pulse) {
}

PulseMeta meta = new PulseMeta(id, description, forced, enabled, defaultEnabled);
meta.setMissingDeps(missingDeps);
meta.setMissingDeps(missingDeps || !hasRequiredPulses(meta, pulseDeps));
meta.setEnabled(getEnabledFromConfig(meta));

if (meta.isEnabled()) {
Expand Down Expand Up @@ -213,13 +214,12 @@ private void preInit(FMLPreInitializationEvent evt) {
blockNewRegistrations = true;
}

private boolean hasRequiredPulses(Map.Entry<Object, PulseMeta> entry) {
String deps = entry.getKey().getClass().getAnnotation(Pulse.class).pulsesRequired();
private boolean hasRequiredPulses(PulseMeta meta, String deps) {
if (!deps.equals("")) {
String[] parsedDeps = deps.split(";");
for (String s : parsedDeps) {
if (!isPulseLoaded(s)) {
log.info("Skipping Pulse " + entry.getValue().getId() + "; missing pulse: " + s);
log.info("Skipping Pulse " + meta.getId() + "; missing pulse: " + s);
return false;
}
}
Expand Down

0 comments on commit 60dd10b

Please sign in to comment.