Added two helper classes for trading with villagers #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progwml6
reviewed
Oct 30, 2016
| * @param random random number access | ||
| * @return A new instance of the input stack, or a stack containing an emerald if null | ||
| */ | ||
| @Nonnull |
There was a problem hiding this comment.
if null is a valid input i'd put @nullable on the random parameter
There was a problem hiding this comment.
Technically it's not, just unused by default. See TradeRandom which extends this (which can easily be done by other classss well for more complicated random functions)
Vanilla only implements this for items instead of stacks. Methods provided allow adding a trade using two inputs for an output and a random input for a random output. Any of those can be empty to default to emeralds
bonii-xx
added a commit
that referenced
this pull request
Apr 10, 2018
* Begin Mantle's update to 1.11. Not everything is 100% completed. * Add jenkinsfile for building using jenkins 2 blue ocean * Bump Mod version, and fix the required Forge version and Minecraft versions. * cleanup build.gradle * add missing gradle plugin * more gradle cleanup/updates * Update Mantle to 1.11.2 + update 1.11 code to match master (1.10.2). * Whoops undo this change! * Clean up some checks to use isEmpty(), which is the same as checking the count is equal to 0. * Reinstate recipematchregistry api * Update RecipeMatch API to return an Optional * Itemstacklist util * Bring itemstacklist.withSize in line with vanilla implementation * Finish optional update * Fix connected block textures * Fix tile inventory * Fix itemstacklist derp * More 1.11 fixes/adjustments * More itemstacklist utility * Validation annotations to make itemstack shenanigans more obvious * Inventory support for itemstacklist * Update Mantle to 1.12, Some things might not work/need to be tested! * Fix "acceptedMinecraftVersions" not accepting 1.12, and bump the required forge version. * Allow Pulse Modules to use the new registration events added with the registry rewrite. * Fix GUI's not having a background as drawDefaultBackground isn't called by drawScreen anymore. * Bump Forge + Mod version, and clean up any Item using addInformation to incude @nullable for the World input. * Fix use of tab instead of spaces. * Fix tooltips not being rendered anymore inside guis. * Fix loading ITooltipFlag on server side. * Change up book loading order to load books after they're registered in preInit * Remove unneeded imports inside Mantle.java and bump the required forge version to the current recommended build. * Fix mantle not calling init() from the proxy, which is used to reload the books * Added two helper classes for trading with villagers (#75) Vanilla only implements this for items instead of stacks. Methods provided allow adding a trade using two inputs for an output and a random input for a random output. Any of those can be empty to default to emeralds * Change books to be lazily loaded. This also kills all of our loading dependency problems. * Version bump * jar tasks gets finalized by reobfJar task - Fixes #94 * Update Configurate * Remove @SideOnly(Side.CLIENT) from getSubBlocks as it is no longer only a client side method. (#103) MinecraftForge/MinecraftForge@368d206 * Remove last clientside only from getSubBlocks #103 * Have heart rendering loop correctly if it surpasses 12 rows of hearts #102 * Fix book crashing when trying to display missing items #99 * Bump version to 1.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vanilla only implements this for items instead of stacks. Methods provided allow adding a trade using two inputs for an output and a random input for a random output. Any of those can be null to default to emeralds (except the second input, where null makes it a single input trade)