Modifier removal fixes

Fix free sponge when using venom (#5026) Fix loss of sponge the second time when not using venom (#5025)
SlimeKnights · Nov 25, 2022 · 1f3735c · 1f3735c
1 parent 6511905
commit 1f3735c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/...ed/resources/data/tconstruct/recipes/tools/modifiers/worktable/remove_modifier_venom.json b/...ed/resources/data/tconstruct/recipes/tools/modifiers/worktable/remove_modifier_venom.json
@@ -21,8 +21,5 @@
         }
       ]
     }
-  ],
-  "leftovers": [
-    "minecraft:sponge"
   ]
 }
diff --git a/src/main/java/slimeknights/tconstruct/tools/data/ModifierRecipeProvider.java b/src/main/java/slimeknights/tconstruct/tools/data/ModifierRecipeProvider.java
@@ -1205,7 +1205,6 @@ private void addModifierRecipes(Consumer<FinishedRecipe> consumer) {
                                  .addInput(CompoundIngredient.of(FluidContainerIngredient.fromFluid(TinkerFluids.venom, false),
                                                                  FluidContainerIngredient.fromIngredient(FluidIngredient.of(TinkerFluids.venom.getLocalTag(), FluidValues.BOTTLE),
                                                                                                          Ingredient.of(TinkerFluids.venomBottle))))
-                                 .addLeftover(Blocks.SPONGE)
                                  .save(consumer, modResource(worktableFolder + "remove_modifier_venom"));
     ModifierSortingRecipe.Builder.sorting()
                                  .addInput(Items.COMPASS)

diff --git a/src/main/java/slimeknights/tconstruct/tools/recipe/ModifierRemovalRecipe.java b/src/main/java/slimeknights/tconstruct/tools/recipe/ModifierRemovalRecipe.java
@@ -123,7 +123,7 @@ public void updateInputs(IToolStackView result, ITinkerableContainer.Mutable inv
     super.updateInputs(result, inv, isServer);
     if (isServer) {
       for (ItemStack stack : leftovers) {
-        inv.giveItem(stack);
+        inv.giveItem(stack.copy());
       }
     }
   }