New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when calling drain(ItemStack) on CastingBlockLogic #1144

Closed

tterrag1098 opened this issue Nov 6, 2014 · 1 comment

tterrag1098 commented Nov 6, 2014

SleepyTrousers/EnderIO-1.5-1.12#1193

Contributor

TherminatorX commented Nov 6, 2014

If crash info works how I think it does, it's this code from TiC:
"if (liquid.getFluid() != resource.getFluid())
return null;

    return drain(resource.amount, doDrain);"

clashing with EIO's (insert old macdonald joke) coding in TileTank at lines 88-90.

Please correct and smack upside the apple if I get this wrong.

Also, push/pull with liquids: wouldn't that be an infinite loop?

bonii-xx added a commit that referenced this issue


          Fix casting logic drain crash with empty basins/tables #1144

37fd426

bonii-xx closed this as completed

CrazyPants mentioned this issue

Ticking block entity issue with Tinkers Construct SleepyTrousers/EnderIO-1.5-1.12#1352

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment