Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Screenshot and Textures #4149

Merged
merged 23 commits into from Jul 26, 2020
Merged

Added Screenshot and Textures #4149

merged 23 commits into from Jul 26, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 13, 2020

1.15 New Textures (3 screenshots)

1.15 New Textures (3 screenshots)
@KnightMiner
Copy link
Member

As I stated multiple times on Discord, screenshots are for the pull request description, so we can see what the textures you are adding look like. Actual textures need to be in the pull request. Put the textures where they belong in the mod, you had to have them there to make the screenshots. We don't care about 1.15 screenshots for the final product, they do not benefit the mod at all and are just so we can see what you changed.

All smeltery blocks & item for 1.15
@ghost ghost changed the title Added Screenshot Added Screenshot and Textures Jul 13, 2020
@ghost
Copy link
Author

ghost commented Jul 13, 2020

2020-07-13_20 26 38
2020-07-13_20 26 41
2020-07-13_20 23 11

@KnightMiner KnightMiner added the 1.15 Pull request related to 1.15 label Jul 21, 2020
@ghost
Copy link
Author

ghost commented Jul 26, 2020

Submited all smeltery textures.
Smeltery part is done

@ghost ghost closed this Jul 26, 2020
@ghost ghost reopened this Jul 26, 2020
@ghost
Copy link
Author

ghost commented Jul 26, 2020

Tinkers Construct is MIT licensed and I agree to MIT licenses for those textures.

@mDiyo mDiyo merged commit ae19257 into SlimeKnights:1.15 Jul 26, 2020
@ghost ghost deleted the 1.15 branch July 26, 2020 19:53
@ghost ghost restored the 1.15 branch July 26, 2020 19:55
@ghost ghost deleted the 1.15 branch July 26, 2020 19:55
@futurenp
Copy link

I approve of my textures being licensed under the MIT license

1 similar comment
@ronuseless
Copy link

I approve of my textures being licensed under the MIT license

@KnightMiner KnightMiner added the Textures Pull requests adding in new textures label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.15 Pull request related to 1.15 Textures Pull requests adding in new textures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants