Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suppress terminal #188

Merged
merged 7 commits into from
Feb 22, 2023
Merged

feat: suppress terminal #188

merged 7 commits into from
Feb 22, 2023

Conversation

marcozzxx810
Copy link
Contributor

@marcozzxx810 marcozzxx810 commented Feb 18, 2023

  • add a show_console flag
  • tested with cargo build --release

@TheButlah
Copy link
Collaborator

Closes #186

@TheButlah
Copy link
Collaborator

TheButlah commented Feb 19, 2023

Needs rebase and for CI to pass. You can turn on formatting on save in your IDE or run cargo fmt to fix the formatting errors.

@TheButlah TheButlah added Area: Overlay Relating to the SteamVR Overlay subproject Type: Enhancement A new feature or improvement labels Feb 19, 2023
Copy link
Collaborator

@TheButlah TheButlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this on windows 11 (which uses windows terminal). The program doesn't appear to actually hide the console window, it remains open.

If I instead use #![windows_subsystem = "windows"] it fully prevents the window from opening - however it then prevents any use from the command line (and ctrl c won't cancel the application, it looks like those signals only work when using the console subsytem), and therefore we won't be able to control if we show the window at launch.

I think we need to investigate a better way that properly works on both the cli and desktop. Maybe we can open a subprocess that does it?

Copy link
Collaborator

@TheButlah TheButlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though on windows terminal this doesn't work, it works on windows 10 where the old terminal is the default. I'll merge since this improves the windows 10 experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Overlay Relating to the SteamVR Overlay subproject Type: Enhancement A new feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants