Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firmware] Use async wifi #199

Merged
merged 12 commits into from
Apr 4, 2023
Merged

[Firmware] Use async wifi #199

merged 12 commits into from
Apr 4, 2023

Conversation

TheButlah
Copy link
Collaborator

@TheButlah TheButlah commented Mar 30, 2023 •
edited
Loading

This simultaneously fixes the broken wifi code, and overhauls it to use embassy-net. This is a WIP.

@TheButlah TheButlah mentioned this pull request Mar 30, 2023
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 30, 2023
View reviewed changes
firmware/src/peripherals/esp32c3.rs Fixed Show fixed Hide fixed
firmware/src/main.rs Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 30, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-advanced-security
Copy link

You have successfully added a new clippy configuration mcu-esp32,net-stubbed,log-uart,,imu-stubbed,fusion-stubbed. As part of the setup process, we have scanned this repository and found 3 existing alerts. Please check the repository Security tab to see all alerts.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 31, 2023
View reviewed changes
firmware/src/main.rs Fixed Show fixed Hide fixed
@github-advanced-security
Copy link

You have successfully added a new clippy configuration mcu-esp32,net-wifi,log-uart,,imu-stubbed,fusion-stubbed. As part of the setup process, we have scanned this repository and found 3 existing alerts. Please check the repository Security tab to see all alerts.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 31, 2023
View reviewed changes
firmware/src/main.rs Fixed Show fixed Hide fixed
@github-advanced-security
Copy link

You have successfully added a new clippy configuration mcu-esp32,net-ble,log-uart,,imu-stubbed,fusion-stubbed. As part of the setup process, we have scanned this repository and found 3 existing alerts. Please check the repository Security tab to see all alerts.

@TheButlah TheButlah requested a review from ImUrX March 31, 2023 03:16
@TheButlah TheButlah marked this pull request as ready for review March 31, 2023 03:25
@TheButlah TheButlah force-pushed the fix-wifi branch 2 times, most recently from 5bca120 to be151a4 Compare March 31, 2023 07:27
@TheButlah
Copy link
Collaborator Author

TheButlah commented Mar 31, 2023 •
edited
Loading

I have tested such that it works on wifi on esp32c3. @ImUrX any chance you can test esp32?
Also, I was unable to get bmi160 to work, but mpu6050 works fine. However, bmi160 worked in the past. I'm not sure what changed. It could just be a hardware issue on my end, perhaps you could test this too?

I also noticed that latency went from 1ms to 7ms. That really sucks, but I don't really know what to do about it. Under the hood, both embassy-net and esp-wifi were using smoltcp, so idk what could have changed other than the async runtime itself or the way that tasks are interleaving.

ImUrX
ImUrX approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@ImUrX ImUrX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine aside from the clippy ignores

@TheButlah TheButlah merged commit 60224d5 into SlimeVR:main Apr 4, 2023
@TheButlah TheButlah deleted the fix-wifi branch April 4, 2023 15:57
@TheButlah TheButlah mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImUrX ImUrX ImUrX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheButlah @ImUrX