Switch to latest gradle and update dependencies #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Okay, then I'll add it back. We might want to keep an eye on this issue anyway. |
It's fixed now; there is no more logging implementation in |
|
nice @hoijui 😄 we should probably bump our version to the latest.. |
|
ohh.. it is not released yet. would you need that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully builds and works (tested most of the functionality, so nothing seems to be borken, but feel free to re-check). Few questions/notes though:
I removedcom.illposed.osc:javaosc-corebecause it's not used anywhere + introduces log4j vulnerabilities (see https://mvnrepository.com/artifact/com.illposed.osc/javaosc-core/0.8). Do we need it at all?Do we needcom.google.guava:guavaanywhere? Removing it from this project andslime-java-commonswould reduce the binary size by 4-5mb and doesn't seem to affect anything.org.slf4j:slf4j-simplewas added since I removedcom.illposed.osc:javaosc-corethat was exposing logging viaslf4j.targetCompatibilityandsourceCompatibility?org.yaml:snakeyamlwas removed since it is already provided byslime-java-commons.Related PR: Eirenliel/slime-java-commons#3