Implement devices and refactor trackers #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also need Eirenliel/slime-java-commons#9 to me merged first |
loucass003
changed the title
|
@Eirenliel this is a lot of changes, please dont bonk me <3 |
|
Still need some testing thats why it is still a draft |
|
Please add description to the PR, or I won't review it :P |
Done sorry <3 |
…uturabeast/SlimeVR-Server into implement-devices-and-refactor-rackers
|
Atight i got the message ..... LOL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Devices. So both UDPTrackers and Feeder VRTrackers have devices and can report infos in the protocol.
The Feeder now declares Devices in the protocol so it can be displayed in the gui.
After that the feeder is probably gonna need an update, i need more infos about the device coming from steamvr.
For now i have put a placeholder for stuff like the manufacturer. (I put "FeederApp" as the manufacturer for now)
In my chase of implementing the device i did a bunch of cleaning the the trackers because it was a mess.
One of the big refactors was to remove the ReferencedAdjustedTracker that was making use do a bunch of wierd tracker replace everywhere, making the code more confusing.
Broke some unit tests on the way, i have no idea how to replace those. Sorry
Also removed some functions from the Tracker interface into Smaller interfaces so it is easier to know what kind of tracker has what by using instanceof
Also fixed the FastList spliterator