Add Remote Command Over WiFi #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDevMinerTV
approved these changes
Jun 30, 2023
|
It'd be cool if you could rebase this onto #256 |
|
pain^2 |
TheDevMinerTV
approved these changes
Jul 2, 2023
nekomona
force-pushed
the
rcmd_merge
branch
2 times, most recently
from
e3d2e80
to
758f8a1
Compare
TheDevMinerTV
requested changes
Jul 4, 2023
TheDevMinerTV
approved these changes
Jul 11, 2023
|
IP check is added, so that remote command would only accept connection from the IP of connected SlimeVR Server. When the server is not connected, any IP could connect to the remote command, but will not receive any response, and only accept the |
|
commit history is a little broken on this and #262 😓 |
|
We squash it so it doesn't matter.. |
|
Rebased to main after v0.4.0 and tested on ESP32-S3, remote commands and server IP checks are looking good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a remote command server running in parallel with the serial command, sharing the same command buffer, command lists, and logger outputs. All the data printed through
Loggerwill be forked to the remote when connected, while the ones usingSerialwon't be forked.The remote command server could be accessed through telnet clients. Would be easy to integrate into server since it use a simple TCP socket to transmit the same data as serial commands do.
Currently this remote command mostly benefits for checking TCAL status remotely, as other commands are mostly for debugging instead of functions. This could be used for future function commands which are too minor to occupy a packet type or doesn't fit well in a UDP packet like largely varying data length.