Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when trying to change or break a sign #25

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Fix error when trying to change or break a sign #25

merged 1 commit into from
Oct 1, 2020

Conversation

michel-zimmer
Copy link
Contributor

Fixes #10

Description

Fix class cast exception when trying to change or break a sign

Changes

Switched to getBlockData inside the sign event handlers.

Related Issues

Resolves #10

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

@michel-zimmer michel-zimmer requested a review from a team as a code owner October 1, 2020 18:44
TheBusyBiscuit
TheBusyBiscuit approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@TheBusyBiscuit TheBusyBiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheBusyBiscuit TheBusyBiscuit added the Hacktoberfest This Issue or Pull Request is part of the Hacktoberfest! label Oct 1, 2020
@TheBusyBiscuit TheBusyBiscuit merged commit f3c452a into Slimefun:master Oct 1, 2020
@mrcoffee1026 mrcoffee1026 mentioned this pull request Sep 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBusyBiscuit TheBusyBiscuit TheBusyBiscuit approved these changes

@poma123 poma123 poma123 approved these changes

Assignees
No one assigned
Labels
Hacktoberfest This Issue or Pull Request is part of the Hacktoberfest!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when trying to break a display sign
3 participants
@michel-zimmer @TheBusyBiscuit @poma123