Chest Terminal duplication bug #879
Comments
This is an attempt to fix the chest terminal duplication issue that seems to mainly be caused by the fact that the cargo network sees the item in the "out slot", registers it but doesn't move it to the network yet until the next call to the scheduled task. This allows the player to take the item before the task is executed, but will still execute the task and thus insert the item if there is enough space. Now, before we attempt any storage operations we first check if there's an item in the "outgoing slot", if there is, we'll try to send it instead of waiting for the next call to Cargo Network's scheduled task. This doesn't seem to impact the system in a negative way and seems to be an appropriate fix for the issue reported here: Slimefun#879
|
Are you using the latest ChestTerminal build, cause the one I used has a lot of non-colored names on its items, and the Wireless terminal items don't work. |
|
The later build fixes the icons but a couple of the slots in the "inventory" of the CT Access terminal... if you put the item in that slot (or even a stack of that item)... and then remove it... it is replenished each time you remove it, regardless of how many items are actually in the network... creating an infinite supply of that item. I tried the latest builds: CS-CoreLib vDEV - 36 (git 2e140f82)
|
So ChestTerminal is unuseable basically? |
|
At least until that glaring duplication glitch is removed? Well I won't be running it. But give them time it's only just been brought to their attention and the addon has only been viable for a little while now since they started working on it again. Not certain but it seemed to me that most of the addons had been relatively untouched since MC 1.8 or so, this is the most action I've seen on them since finding Slimefun in the first place so just keep an eye on the repo server for new developments. |
Description (Required)
The ChestTerminal plugin for Slimefun has an item duplication bug that can be exploited by dragging an item into the cyan/blue bordered item slot and then dragging it out fast enough for it to still be "sucked into" the cargo system but not be removed from the item slot.
The item will then be added to the terminal and attached cargo nodes but will also still be in the player's possession, allowing them to repeat the same procedure over and over.
Reproducing this is easier than it sounds, as can be seen in the video below.
This issue looks very similiar to the one reported in ChestTerminal itself- TheBusyBiscuit/ChestTerminal#4.
It seems that the issue is not in ChestTerminal (that plugin actually does very little with the actual terminal management and item transport), but it seems to be related to the way the "Cargo Network" within Slimefun handles terminals.
Server Log
n/a
Evidence / Proof (Required)
Here's a small video (click to open) that shows me obtaining 64 diamond blocks and then exploiting the duplication bug to gain more and more:
Environment (Required)
Paper v1_13_R2
CS-CoreLib vDEV - 36
Slimefun vDEV - 87
ChestTerminal (master)
The text was updated successfully, but these errors were encountered: