-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Java 16 #3602
Update to Java 16 #3602
Conversation
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
Co-authored-by: TheBusyBiscuit <TheBusyBiscuit@users.noreply.github.com>
# Conflicts: # src/main/java/io/github/thebusybiscuit/slimefun4/api/items/SlimefunItem.java
Java16 Sonar Changes
FYI, I am happy to do those stream changes noted in the sonar list but I can't be entirely sure when a collection is required as immutable or not. While I could go through and check every usage I feel that may be better served by those who know the code base far better than myself. |
...va/io/github/thebusybiscuit/slimefun4/implementation/items/multiblocks/miner/MiningTask.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment on the Chest patterns but even then it's still fine. So LGTM
@WalshyDev Do you perhaps have time to give this a look? 👀 |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
This PR updates Slimefun to Java 16.
This is a breaking update for any servers that run older versions of Java.
Please update your Java version immediately!
This PR is still in progress. There are a lot of advantages that come with the usage of Java 16 and it would be nice to take advantage of most if not all of them.
I compiled a list of relatively easy to implement patterns here:
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS5194%2Cjava%3AS6201%2Cjava%3AS6204%2Cjava%3AS6206&types=CODE_SMELL&id=Slimefun_Slimefun4
Anyone can contribute!
Feel free to PR to this branch with a few changes from the list above ❤️
The following newly available patterns are desirable:
"instanceof + cast"
switch expressions
and various other patterns, check the sonarcloud link for more details.
Of course any other sonarcloud issue is always up for grabs too!
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values