-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorization middleware, fixes to API and User PATCH #87
Conversation
Two (possibly) issues so far:
Currently this is how middleware is wrapped: Authentication(Authorization(Site)) and it is annoying. More: https://stackoverflow.com/questions/43978021/update-change-roles-claim-or-any-other-claim-in-jwt |
Codecov Report
@@ Coverage Diff @@
## dev #87 +/- ##
==========================================
- Coverage 48.12% 48.04% -0.08%
==========================================
Files 16 18 +2
Lines 374 487 +113
==========================================
+ Hits 180 234 +54
- Misses 194 253 +59
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
merged locally n pushed to dev |
This PR implements Role-Based Authorization middleware, where Role is stored in UserDTO encoded into JWT. It also implements PATCH endpoints required for promotion, and user edits. Fixes to API are cosmetic.