Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Minecraft versions in ModPack filter. Fixes #571. #676

Closed
wants to merge 1 commit into from
Closed

Sort Minecraft versions in ModPack filter. Fixes #571. #676

wants to merge 1 commit into from

Conversation

rce
Copy link

@rce rce commented Mar 14, 2014

No description provided.

Signed-off-by: Henry Heikkinen <rce@rce.fi>
@jamierocks
Copy link
Contributor

A possible solution would be to have a json/xml file with all the minecraft versions (in order) the launcher is compatible with, and have it get the order from there.

@progwml6
Copy link
Collaborator

we are not hardcoding that stuff there are other minor MC versions all over 3rd party packs

@jamierocks
Copy link
Contributor

Shame, I think Mojang hosts a json file with all MC versions (in order) for their launcher.

@jikuja
Copy link
Collaborator

jikuja commented Oct 14, 2014

Or make generic Version class which implements Comparable or Comparator and use it as base class for java versions, pack versions and mc versions.

I have some kind of code and tests, but it still need work before I will push it.

Edit. By generic I mean unlimited separator count per version string, multiple separator(.-_), maybe even configurable separator.

@jamierocks
Copy link
Contributor

@progwml6
Copy link
Collaborator

i am well aware of those files however... that is not the solution to this problem it adds additional file IO for no reason when we can just use comparable/comparators on version #'s

@jamierocks
Copy link
Contributor

version #?

@jikuja
Copy link
Collaborator

jikuja commented Oct 14, 2014

And using external files does not solve sorting other things...

@rce rce closed this Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants