Update kkbox.py #79
Closed
Update kkbox.py #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want to download all albums of an artist, only the albums shown in https://play.kkbox.com/artist/XXXXXXXXXXXXXX will be downloaded. But this is only a part of this artist's albums, not all of this artist's albums. his all albums are showcased at https://play.kkbox.com/artist/DXQVoCQF1asjEu9yaW/albums. and should be downloaded from here In addition, you seem to use the 'get_date' function in ' rsack\clients\kkbox.py ' to capture the release time of the album through ' Beautifulsoup'. In fact, the release time of the album can also be obtained from 'get_artist_albums' (In addition, I had the log print out the name of the album currently being downloaded)
|
Bs4 is indeed used as I could not find the date anywhere in the API response. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to download all albums of an artist, but only the albums shown in https://play.kkbox.com/artist/XXXXXXXXXXXXXX will be downloaded.
But this is only a part of this artist's albums, not all of this artist's albums. his all albums are showcased at https://play.kkbox.com/artist/xxxxxxxxxxxxxx/albums. and should use “get_artist_albums” function to download from here
In addition, you seem to use the 'get_date' function in ' rsack\clients\kkbox.py ' to capture the release time of the album through ' Beautifulsoup'. Actually, the release time of the album can also be obtained from 'get_artist_albums'
I feel that it is only suitable for batch downloading all albums of an artist. If only one album is downloaded, the current method is more convenient
(I have the log print out the name of the album currently being downloaded, so it looks a little clearer)
hope there is nothing wrong