Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #9

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Add Dockerfile #9

merged 1 commit into from
Jul 31, 2019

Conversation

iakat
Copy link

@iakat iakat commented Jul 30, 2019

If you could enable https://docs.docker.com/docker-hub/builds/, that'd be great!

@SmCTwelve
Copy link
Owner

Thanks I'll add it!

I'm not sure automated builds will be of any use here. Running the bot requires a Token key which is different per bot account, so I think the image won't run for anyone who downloads it. The repo has no Token just a placeholder. At least with the Dockerfile they can build their own local image using a Token in config.ini or env var.

@SmCTwelve SmCTwelve merged commit 5b4b153 into SmCTwelve:master Jul 31, 2019
@iakat
Copy link
Author

iakat commented Jul 31, 2019

You can set your own environment variables on Docker, and mount files.
This is how I am running the bot.
By the time I need to set something on config.ini, I'll probably change the code to support env vars instead of reading the config file.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants