Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HTTPS, http is no longer supported #215

Closed
wants to merge 1 commit into from
Closed

Added HTTPS, http is no longer supported #215

wants to merge 1 commit into from

Conversation

amit177
Copy link

@amit177 amit177 commented Apr 5, 2018

No description provided.

Copy link

@Marcuzz Marcuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backwards compatibility incase Valve changes their mind

header('Location: ' . $openid->authUrl());
} elseif ($openid->mode == 'cancel') {
echo 'User has canceled authentication!';
} else {
if($openid->validate()) {
$id = $openid->identity;
$ptn = "/^http:\/\/steamcommunity\.com\/openid\/id\/(7[0-9]{15,25}+)$/";
$ptn = "/^https:\/\/steamcommunity\.com\/openid\/id\/(7[0-9]{15,25}+)$/";
Copy link

@Marcuzz Marcuzz Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use https? instead of https incase they decide to switch again

@RedSparr0w
Copy link
Contributor

userinfo.php line 4 will also need to be updated

@SmItH197
Copy link
Owner

SmItH197 commented Apr 6, 2018

Thanks for this, I'll take a look now!

@SmItH197
Copy link
Owner

SmItH197 commented Apr 6, 2018

Hi, I've merged #218 instead as it made more changes and included the above suggestions from @Marcuzz and @RedSparr0w

@SmItH197 SmItH197 closed this Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants